Improve preserve cache #1382
Merged
Improve preserve cache #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptonemo
requested review from
dignifiedquire and
porcuquine
as code owners
| // If 'preserve_cache' is specified, the 'cache' option must be specified and must not exist on disk. | ||
| if preserve_cache { | ||
| ensure!( | ||
| cache_dir_specified && !Path::new(&PathBuf::from(&cache)).exists(), |
There was a problem hiding this comment.
you shouldn’t need the Path::new
There was a problem hiding this comment.
Thanks, didn't realize!
dignifiedquire
approved these changes
Dec 2, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Window post bench preserve_cache option should only be used on new/non-existent cache dirs. This check enforces this.
This PR also removes an unrelated unused argument.