-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
reset consumer #1535
reset consumer #1535
Conversation
The bug you mentioned doesn't seem to be due to the consumer value. |
I think you are right. |
I've only had a quick look, but to me it sounds like it is the right thing to do, to also reset the consumer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@firesWu Sorry for the long delay. I know had a closer look. You change looks absolutely right. Thanks for spotting this issue. I was recently also deep into that part of the code, but I haven't spotted this issue. Good job!
Could you please rebase your change to current master (so that we don't end up with strange merge commits)?
19d1f15
to
7a96387
Compare
@vmx I have rebase my change to current master |
Reset consumer every time when finish one layer.
If consumer not reset, may cause parent cache loading problem.
cur_parent_ptr
may point to a released memory location, causing panic.cur_parent_ptr
may point to a wrong parent cache window, resulting wrong pc1 result.