chore: lock versions to the correct minor, and update #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
requested review from
dignifiedquire,
cryptonemo,
DrPeterVanNostrand and
vmx
as code owners
1. Update minimum versions for in-workspace crates. 2. Use the tilde constraint to ensure that we don't update to the next minor version. The next minor version is going to revert the change.
Stebalien
force-pushed
the
fix/lock-versions
branch
from
e5dc008 to
4a9a4c0
Compare
cryptonemo
approved these changes
Jun 14, 2022
|
is CI sad because it was opened from a fork? |
No that's not the issue. I think I know how to fix that. |
|
@arajasek I was wrong, it was the issue. Though, this PR should be green soon. |
|
@vmx CI still sad :( |
|
Looks like something timed out. |
Stebalien
force-pushed
the
fix/lock-versions
branch
from
02e7ad5 to
90c56b0
Compare
|
It's failing to fetch parameters. I'm seeing if I can get that working. |
|
|
For the record: this exact change passed all tests, when the CI was fixed. It's shown at #1614. |
cryptonemo
added a commit
that referenced
this pull request
Jul 22, 2022
* feat: extend proofs API such that aggregation can use snarkpack versions * feat: extend aggregation tests to ensure version incompatibility * feat: update bellperson and neptune to latest * feat: update CI nightly * feat: update dependencies * feat: lock versions so only patch releases are allowed Based on #1613 * feat: update merkletree to latest release * docs: update changelog for release * docs: update changelog for release * feat: update neptune to the latest release
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the next minor release (which will re-release the changes on master) will break anything depending on this release.
NOTE: we should also go ahead and release those minor releases. This is kind of hard to test otherwise.