chore: downgrade neptune to 5.1.x #1618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downgrading `neptune` makes the master branch build again.
vmx
requested review from
dignifiedquire,
cryptonemo and
DrPeterVanNostrand
as code owners
|
I'm preferring #1615 to this and may merge. We were waiting on @porcuquine to release Neptune v7, but could merge while it's still a neptune branch if causing issues. |
|
Downgrading neptune is good workaround, but it doesn't free us from updating bellperson here in rust-fil-proofs. And unfortunately we will get this issue with build again and again when versions of bellperson become different. Should we may be prefer upgrading dependencies rather than downgrading? |
|
Closing since #1615 was merged |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downgrading
neptunemakes the master branch build again.