Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: update rust-toolchain to 1.62.0 #1623

Merged
merged 2 commits into from
Aug 5, 2022
Merged

feat: update rust-toolchain to 1.62.0 #1623

merged 2 commits into from
Aug 5, 2022

Conversation

cryptonemo
Copy link
Collaborator

No description provided.

Copy link
Contributor

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the reasons for the upgrade?

I think it should be 1.62.1.

@cryptonemo
Copy link
Collaborator Author

What are the reasons for the upgrade?

I think it should be 1.62.1.

No particular reason -- we just did a release, so starting the next cycle with the latest toolchain seems reasonable since we'll be testing everything from here.

Please push the update to 1.62.1 if you'd like.

Use the most recent stable release.
@vmx
Copy link
Contributor

vmx commented Aug 5, 2022

No particular reason -- we just did a release, so starting the next cycle with the latest toolchain seems reasonable since we'll be testing everything from here.

I'd say it's generally good practice in the Rust world to stay on the lowest possible version. But I can see how this produces less work for us.

@cryptonemo
Copy link
Collaborator Author

Looks good, but I can't approve my own PR :-)

@cryptonemo cryptonemo merged commit 380d643 into master Aug 5, 2022
@cryptonemo cryptonemo deleted the update-toolchain branch August 5, 2022 19:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants