refactor: StackedCircuit only needs the number of layers #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrPeterVanNostrand
previously approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Looks good to me.
Theoretically I think that StackedCircuit doesn't even need to store num_layers because the circuit prover implicitly stores num_layers in the circuit's private inputs (i.e. in the column proofs) and the circuit verifier generates circuit public inputs by passing pub_params into StackedCompound::generate_public_inputs.
|
@DrPeterVanNostrand good point! I've created #1735 as I'm not sure if that's what you meant and also not sure if we really want to do that. |
vmx
force-pushed
the
split-layer-and-challenges
branch
from
1fc3399 to
329eacb
Compare
vmx
force-pushed
the
split-layer-and-challenges
branch
from
329eacb to
9b129ce
Compare
There's no need to store the full public parameters within the `StackedCircuit` struct, as it only needs the number of layers.
vmx
force-pushed
the
stacked-circuit-num-layers
branch
from
dab8b31 to
a1843e5
Compare
DrPeterVanNostrand
approved these changes
Dec 1, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to store the full public parameters within the
StackedCircuitstruct, as it only needs the number of layers.