Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

Fip 0021 #1487

Merged
merged 14 commits into from
Sep 29, 2021
Merged

Fip 0021 #1487

merged 14 commits into from
Sep 29, 2021

Conversation

ZenGround0
Copy link
Contributor

@ZenGround0 ZenGround0 commented Sep 21, 2021 •
edited
Loading

@ZenGround0 ZenGround0 force-pushed the feat/psd-error-handling branch from d61c97a to a1c2658 Compare September 22, 2021 21:47
@ZenGround0 ZenGround0 marked this pull request as ready for review September 23, 2021 17:56
@ZenGround0 ZenGround0 requested a review from a team as a code owner September 23, 2021 17:56
@ZenGround0 ZenGround0 changed the title Draft PR for fip 0021 Ffip 0021 Sep 23, 2021
@ZenGround0 ZenGround0 changed the title Ffip 0021 Fip 0021 Sep 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021 •
edited
Loading

Codecov Report

Merging #1487 (5aa9ee3) into master (456c151) will decrease coverage by 0.0%.
The diff coverage is 88.4%.

@@           Coverage Diff            @@
##           master   #1487     +/-   ##
========================================
- Coverage    71.4%   71.4%   -0.1%     
========================================
  Files          72      72             
  Lines        8546    8601     +55     
========================================
+ Hits         6109    6148     +39     
- Misses       1553    1563     +10     
- Partials      884     890      +6

@jennijuju jennijuju added this to the Network v14 milestone Sep 25, 2021
@ZenGround0 ZenGround0 force-pushed the feat/psd-error-handling branch from a7b4f65 to 2afc142 Compare September 26, 2021 19:22
@ZenGround0 ZenGround0 removed the request for review from Stebalien September 26, 2021 19:22
@ZenGround0 ZenGround0 force-pushed the feat/psd-error-handling branch from b65837c to e21a485 Compare September 27, 2021 15:07
@ZenGround0 ZenGround0 force-pushed the feat/psd-error-handling branch from 22e14eb to 92f45e5 Compare September 28, 2021 20:17
arajasek
arajasek reviewed Sep 29, 2021
View reviewed changes
Copy link
Collaborator

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some qs

actors/builtin/market/market_actor.go Outdated Show resolved Hide resolved
actors/builtin/market/market_actor.go Show resolved Hide resolved
actors/builtin/market/market_actor.go Show resolved Hide resolved
actors/builtin/market/market_actor.go Outdated Show resolved Hide resolved
actors/builtin/market/market_actor.go Outdated Show resolved Hide resolved
actors/builtin/market/market_actor.go Show resolved Hide resolved
@ZenGround0 ZenGround0 requested a review from arajasek September 29, 2021 14:42
@ZenGround0 ZenGround0 merged commit 9dcf49d into master Sep 29, 2021
@ZenGround0 ZenGround0 mentioned this pull request Oct 4, 2021
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@arajasek arajasek arajasek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Network v14
Development

Successfully merging this pull request may close these issues.
5 participants
@ZenGround0 @codecov-commenter @arajasek @Stebalien @jennijuju