Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: implement eth_getCode and eth_getStorageAt #5572

Merged
merged 4 commits into from
Dec 15, 2022

Conversation

simlecode
Copy link
Collaborator

关联的Issues (Related Issues)

#5550

filecoin-project/lotus#9397
filecoin-project/lotus#9511
filecoin-project/lotus#9531
filecoin-project/lotus#9532

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@simlecode simlecode requested a review from diwufeiwen December 15, 2022 02:35
@simlecode simlecode self-assigned this Dec 15, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #5572 (624e834) into feat/nv18-fevm (fdadbd4) will decrease coverage by 0%.
The diff coverage is 2%.

Additional details and impacted files
@@               Coverage Diff               @@
##           feat/nv18-fevm   #5572    +/-   ##
===============================================
- Coverage              26%     26%    -1%     
===============================================
  Files                 619     619            
  Lines               71026   71135   +109     
===============================================
+ Hits                18490   18500    +10     
- Misses              50064   50163    +99     
  Partials             2472    2472            

Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diwufeiwen diwufeiwen merged commit dc81c74 into feat/nv18-fevm Dec 15, 2022
@diwufeiwen diwufeiwen deleted the feat/eth-code-storage branch December 15, 2022 03:04
@simlecode simlecode added the nv18 nv18-fevm label Dec 15, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
nv18 nv18-fevm
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants