Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Code Quality: Convert into await using statement or declaration #16694

Merged
merged 2 commits into from
Jan 26, 2025
Merged

Code Quality: Convert into await using statement or declaration #16694

merged 2 commits into from
Jan 26, 2025

Conversation

andreistaravoitau
Copy link
Contributor

Resolved / Related Issues

Steps used to test these changes

  1. Opened Files with the updated code.
  2. Verified that resources are disposed of asynchronously without blocking the UI.
  3. Tested all affected scenarios for stability, including:
  • Opening and closing files
  • Performing file operations (e.g., move, copy, delete)
  • Handling zip files.

@yaira2 yaira2 changed the title Convert into await using statement or declaration Code Quality: Convert into await using statement or declaration Jan 9, 2025
@yaira2 yaira2 requested a review from gave92 January 13, 2025 23:29
@yaira2 yaira2 requested a review from 0x5bfa January 23, 2025 16:41
@0x5bfa
Copy link
Member

0x5bfa commented Jan 23, 2025

Code wise, LGTM.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 26, 2025
@yaira2 yaira2 merged commit 02c2320 into files-community:main Jan 26, 2025
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Lamparter Lamparter Lamparter left review comments

@gave92 gave92 gave92 approved these changes

@0x5bfa 0x5bfa Awaiting requested review from 0x5bfa

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code Quality: Convert into await using statement or declaration
5 participants
@andreistaravoitau @0x5bfa @gave92 @Lamparter @yaira2