Skip to content

Code Quality: Added root files to projects to make them easier to edit #16815

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

Lamparter
Copy link
Contributor

Adds Directory.Packages.props, Directory.Build.props and .editorconfig to all projects as None to make them appear in Solution Explorer. This makes them easier to edit.

@Lamparter Lamparter force-pushed the include-primitives branch from 161f92e to a686b9b Compare March 2, 2025 07:46
@Lamparter Lamparter requested a review from yaira2 March 2, 2025 07:47
@yaira2 yaira2 requested a review from hez2010 March 2, 2025 15:19
@hez2010
Copy link
Member

hez2010 commented Mar 3, 2025

I personally don't like this change as solution-wide files shouldn't appear as project-wide items, instead it should be placed under the solution hierarchy directly IMO. So I'm sorry but I hesitate to approve this change.
While I'm not strongly against it if other members think it's fine.

@Lamparter
Copy link
Contributor Author

They apply to all the projects; that's my logic for them being included in all of them.

@marcofranzen99
Copy link
Contributor

marcofranzen99 commented Mar 3, 2025

I would have also expected the files to be in a Solution Items folder. I think the files are also rarely needed and would rather distract from the individual projects when navigating in the Solution Explorer than in a separate Solution Items folder.

This is how i usually do it my private projects:
image

But this might also be just personal preference

@0x5bfa
Copy link
Member

0x5bfa commented Mar 3, 2025

I don't approve either. It doesn't need to be everywhere and should not.

This is how i usually do it my private projects:

I think this is also what Hez has in his mind too.

@yaira2
Copy link
Member

yaira2 commented Mar 10, 2025

@Lamparter thank you for the PR. Currently the community would prefer not to adopt this change, but we appreciate the contribution as always and hope to find other areas where we can collaborate 🙂

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants