Habilita mais regras do ESLint #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable some useful ESLint rules to facilitate PR reviews and also to avoid errors when creating a commit.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aprendendofelipe
approved these changes
Jun 13, 2024
|
Massa! 🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mudanças realizadas
Estou habilitando algumas regras úteis do ESLint para facilitar revisões de PR e também para evitar erros ao criar um commit.
prefer-const: percebi a necessidade no PR Tests e2e utilizando playwright com relatório #1716, onde algumas variáveis eram declaradas comlet, apesar de serem constantes.vitest/no-focused-tests: essa eu habilitei no PR Reverter ganhos de TabCoins em conteúdos pegos pelo firewall interno e outros ajustes #1638 (ainda não mesclado) há alguns meses porque já quase esqueci de remover o.onlyem alguns testes.vitest/require-to-throw-message: pequena melhoria que ajuda a garantir que oexpectrealmente testa o que é esperado. Resultou em uma modificação no testeSpamming valid usersem/api/v1/users/firewall.post.test.js.