Switch manylinux image. #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsokol
reviewed
Nov 14, 2024
Comment on lines
+27
to
+28
| manylinux-x86_64-image = "manylinux_2_28" | ||
| manylinux-pypy_x86_64-image = "manylinux_2_28" |
There was a problem hiding this comment.
I'm trying to get pixi to work -- no idea if it will though. 😢
There was a problem hiding this comment.
I think I prefer to leave it open for now. We have working wheels now I would avoid interfering with build process to not to spend more time on this.
Once we have MVP of Finch mlir dialect and we need to iterate on the build process once again, we can include it.
|
We don't need this anymore as a bug was identified inside |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.