Adding stats functions #694
Conversation
|
Let's also check that the shape of the lazy tensors is always equal to the shape of the returned tensors when in debug mode using an |
willow-ahrens
force-pushed
the
dp/stats
branch
3 times, most recently
from
4054792 to
edcb1ca
Compare
| @@ -111,7 +109,8 @@ function remove_reorders(prgm::LogicNode) | |||
| if length(idxs2) < length(getfields(arg)) | |||
| reorder( | |||
| aggregate( | |||
| nothing, nothing, arg, setdiff(getfields(arg), idxs2)... | |||
| overwrite, nothing, arg, | |||
There was a problem hiding this comment.
@kylebd99, I found this was necessary to get things to work, and I'm not sure why. The issue was that merge_stats_def would try to evaluate the aggregate function because the original rule to remove isnothing(init) aggregates never matched. I'm just confused about how we never hit this before.
There was a problem hiding this comment.
Hmm, yeah I don't have a lot of intuition on this one. It seems like the original version should have checked isnothing on op not init. But, I'm quite surprised that it was never firing.
Codecov ReportAttention: Patch coverage is
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
fixes #574
Implementing size property to lazy tensors to use with stats functions.