-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ENH: linalg
module, mT
property, and multiple outputs from @compiled
#94
Conversation
…utputs from `compiled` kernels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested a few simplifications to the code. The overall logic of the PR LGTM.
A test for multiple-return would also be appreciated. |
Done! |
I'm surprised that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hameerabbasi Thanks for improving the nesting returns logic!
Left last comments, and maybe one last thing is a test which covers:
@compiled()
def foo_bar(a: Tensor, b: Tensor, c: int):
c = a + b
d = c ** 2
return (a, c, (b, "text"), {"key1": 12, "key2": d})
The test caught some bugs! Thanks for the suggestions, @mtsokol. |
Hi @hameerabbasi,
This PR introduces improvements that my
pydata/sparse
use-case requires:linalg
module with the first function,vector_norm
.mT
array class property.@compiled
decorator accepting multiple outputs.