Update JavaVersion for JEP 223 compatibility #75
Conversation
JEP 223 introduces a new version scheme for Java versions >= 9
|
So do you think that "1.9.0-ea-b19" and "9-ea+19" should produce different Major version? I doubt that it's useful. Probably it's better to have major = 1, minor = 9 even for "9-ea+19". |
|
I don't know what's the best solution. I chose the easiest solution, but I'm not familiar enough with Findbugs code and implications of the meaning of major/minor version. I though about the other way: considering "1.7" as equals to "7", to be consistent with new scheme. But that would imply some incompatiblity with previous versions of Findbugs, I don't know if that's OK. |
|
I'm starting to look at Java 9 support and I will follow up soon. |
The right approach would be something like #75.
FB follows now the new JDK version scheme described in http://openjdk.java.net/jeps/223. Java versions before Java 9 will have 1 as major segment, and some meaningful number as major segment starting with Java 9. This should work for most cases.
|
Vincent, I've committed a simple parsing fix to the java9 branch, see This is not as complex as a regex, but I think it should just work. Can you please adopt your test case and create another PR with that, so that I can merge it on java9 branch, or should I simply do it by myself (your commit info will be not preserved then)? |
|
It's OK to make the changes directly without my commit information :) It's a long time since I wrote this PR and I don't remember anymore how it works ^^ I'm very grateful you start working on Java 9 support btw ! |
Contributed by Vincent Privat, see #75
|
Thanks Vincent, the (slightly modified) test is now on the java9 branch. |
|
thanks! We will try the development versions very soon in our project 👍 |
The right approach would be something like findbugsproject#75.
…oject#75 FB follows now the new JDK version scheme described in http://openjdk.java.net/jeps/223. Java versions before Java 9 will have 1 as major segment, and some meaningful number as major segment starting with Java 9. This should work for most cases.
Contributed by Vincent Privat, see findbugsproject#75
JEP 223 introduces a new version scheme for Java versions >= 9:
http://openjdk.java.net/jeps/223
This fixes https://sourceforge.net/p/findbugs/bugs/1432