Dbconnection update #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like this update to dbconnection got abandoned. |
|
Ebert has finished reviewing this Pull Request and has found:
But beware that this branch is 28 commits behind the You can see more details about this review at https://ebertapp.io/github/findmypast-oss/mssqlex/pulls/16. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #15 for more details.
The update doesn't provide a lot of benefit to
mssqlexas everything is a transaction with ODBC, but have added it where it makes sense.Please don't merge in until DBConnection update has been released through Hex.