lint python as well

finos · Dec 19, 2023 · 39128bc · 39128bc
1 parent 2f90826
commit 39128bc
Showing 1 changed file with 18 additions and 2 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -328,8 +328,6 @@ jobs:
                   sudo ./llvm.sh 16
                   sudo apt-get install -y clang-tidy-16
                   echo "$(dirname $(realpath $(which run-clang-tidy-16)))" >> $GITHUB_PATH
-              # sudo update-alternatives --install /usr/bin/clang-tidy clang-tidy /usr/bin/clang-tidy-16 100
-              # sudo update-alternatives --install /usr/bin/run-clang-tidy run-clang-tidy /usr/bin/run-clang-tidy-16 100
 
             #~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
             #~~~~~~~~~ Build Pipelines ~~~~~~~~~#
@@ -1072,6 +1070,17 @@ jobs:
             #   run: sudo node tools/perspective-scripts/install_tools.mjs
             #   if: ${{ runner.os == 'Linux' }}
 
+            - name: Install newer version of clang-tidy
+              if: ${{ matrix.os == 'ubuntu-20.04' }}
+              run: |
+                  sudo apt-get update
+                  sudo apt-get install -y software-properties-common
+                  wget https://apt.llvm.org/llvm.sh
+                  chmod +x llvm.sh
+                  sudo ./llvm.sh 16
+                  sudo apt-get install -y clang-tidy-16
+                  echo "$(dirname $(realpath $(which run-clang-tidy-16)))" >> $GITHUB_PATH
+
             ################
             # Mac
             - name: Install Boost (MacOS)
@@ -1103,6 +1112,13 @@ jobs:
                   PSP_DOCKER: 1
               if: ${{ matrix.os == 'ubuntu-20.04' }}
 
+            - name: C++ Lint
+              run: yarn lint # C++ lints only works if we configure cmake first
+              if: ${{ matrix.os == 'ubuntu-20.04' }}
+              env:
+                  PSP_LINT_ONLY: "cpp"
+                  PSP_PROJECT: "python"
+
             ########
             # Macos
             - name: Python Build Steps (Macos)