Fix in and not in filter UI bug
#2403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
force-pushed
the
fix-in-notin-filter-python
branch
from
9824389 to
5b9392a
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Python virtually from a
<perspective-viewer>, theinandnot infilter types may generate messages of the form["Column", "in", ["val1", ..]], which both the JavaScript and Python backends support. However, a bug in<perspective-viewer>caused completions triggered by the auto-complete widget to not encode this correctly, keeping it as a comma-separated string. While the JavaScript Emscripten API gracefully falls back in this case, the Python C++ APIget_viewer_config()strictly (but correctly) rejects this.Reported in #2397