Integrate protobuf #2471
Closed
Integrate protobuf #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Setup ClangD with Emscripten/Python. Fixes: * Fix boost include shadowing local headers.
…ing. We'll now need `protoc` installed locally to build, this will use that to parse the protobuf version used in the CLI and checkout/build the correct version based on what the user has locally. Changes: * Make psp_build_dep always output to the top-level target's binary dir. * Improve error reporting in psp_build_dep so that errors aren't white text above the top level error message. * Workaround templating issue with external dependencies. * Adds Protoc integration module that uses the globally installed `protoc` and provides helpers for building C++ modules from them.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integrates protobuf into the cmake build using some modular tooling. We'll now need
protocinstalled locally to build, this will use that to parse the protobuf version used in the CLI and checkout/build the correct version based on what the user has locally.Changes:
protocand provides helpers for building C++ modules from them.Depends on this PR being merged.