Skip to content

feat(fcm): Add FcmOptions on MulticastMessage #439

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2020
Merged

feat(fcm): Add FcmOptions on MulticastMessage #439

merged 1 commit into from
Jun 9, 2020

Conversation

pavlospt
Copy link
Contributor

@pavlospt pavlospt commented Jun 9, 2020 •
edited by hiranya911
Loading

MulticastMessage does not seem to support FcmOptions. This PR introduces FcmOptions in MulticastMessages.

The implementation follows the same approach with the NodeJS SDK.

https://github.com/firebase/firebase-admin-node/blob/master/src/messaging/messaging.ts#L361

Resolves #440

@pavlospt pavlospt mentioned this pull request Jun 9, 2020
Closed
hiranya911
hiranya911 suggested changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @pavlospt. Looks mostly good. Just a couple of updates needed.

@hiranya911 hiranya911 changed the title Add FcmOptions on MulticastMessage feat(fcm): Add FcmOptions on MulticastMessage Jun 9, 2020
@pavlospt
Copy link
Contributor Author

pavlospt commented Jun 9, 2020

Thanks for the PR @pavlospt. Looks mostly good. Just a couple of updates needed.

Hey @hiranya911 thank you for your review. I have updated the PR accordingly 😄 !

@pavlospt pavlospt requested a review from hiranya911 June 9, 2020 19:28
hiranya911
hiranya911 approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

@hiranya911 hiranya911 merged commit 3485c98 into firebase:master Jun 9, 2020
@pavlospt pavlospt deleted the feature/multicase-message-fcm-options branch June 9, 2020 19:58
@pavlospt
Copy link
Contributor Author

pavlospt commented Jun 9, 2020

@hiranya911 Sorry for the question, but since this is a thing we will be needing ASAP, I feel like I need to ask 😂 . Do we know when we can have a release including it? 😄

@hiranya911
Copy link
Contributor

@pavlospt we can try to get a release out next week.

@pavlospt
Copy link
Contributor Author

pavlospt commented Jun 9, 2020

@hiranya911 cool thank you very much 😄 !

@pavlospt
Copy link
Contributor Author

Hey @hiranya911 is the release still planned to be published this week 😄 ?

@lahirumaramba
Copy link
Member

lahirumaramba commented Jun 17, 2020 •
edited
Loading

This change is now released in v6.14.0
https://github.com/firebase/firebase-admin-java/releases/tag/v6.14.0

Thank you for your contribution!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

Assignees

@pavlospt pavlospt

@hiranya911 hiranya911

Labels
release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FR: FcmOptions on MulticastMessage
3 participants
@pavlospt @hiranya911 @lahirumaramba