Skip to content

chore: Update pypy tests to 3.8 #694

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 5, 2023
Merged

chore: Update pypy tests to 3.8 #694

merged 1 commit into from
Apr 5, 2023

Conversation

lahirumaramba
Copy link
Member

@lahirumaramba lahirumaramba commented Apr 5, 2023

  • pytest crashes on pypy3.7 blocking the release pipelines. The error logs are also not very helpful. It could be a transitive dependency that has dropped support for pypy3.7 that's causing the issue.
  • Upgrading pypy CI to pypy3.8 to unblock the releases.

@lahirumaramba lahirumaramba force-pushed the lm-fix-pypy branch 7 times, most recently from a9d22d0 to 92404d4 Compare April 5, 2023 23:26
@lahirumaramba lahirumaramba changed the title chore: Fix pypy tests chore: Update pypy tests to 3.8 Apr 5, 2023
@lahirumaramba lahirumaramba requested a review from hsubox76 April 5, 2023 23:30
@lahirumaramba lahirumaramba merged commit 6ae9408 into master Apr 5, 2023
@lahirumaramba lahirumaramba deleted the lm-fix-pypy branch April 5, 2023 23:55
Doris-Ge pushed a commit that referenced this pull request May 15, 2023
pragatimodi pushed a commit that referenced this pull request May 26, 2023
Doris-Ge added a commit that referenced this pull request Jun 7, 2023
* Add integration tests for send_each and send_each_for_multicast

Add test_send_each, test_send_each_500 and test_send_each_for_multicast

* chore: Fix pypy tests (#694)

* chore(auth): Update Auth API to `v2` (#691)

* `v2beta1` -> `v2`

* Reverting auto formatting changes

* undo auto formatting

* Add release notes to project URLs in PyPI (#679)

It's useful to be able to navigate to the release notes easily
from the package index when upgrading.

"Release Notes" is a special keyword that will have the scroll icon
in the project page.

A random example:

* https://pypi.org/project/streamlit/
* https://github.com/streamlit/streamlit/blob/815a3ea6fa3e7f9099b479e8365bd3a5874ddc35/lib/setup.py#L111

Co-authored-by: Lahiru Maramba <llahiru@gmail.com>

---------

Co-authored-by: Lahiru Maramba <llahiru@gmail.com>
Co-authored-by: pragatimodi <110490169+pragatimodi@users.noreply.github.com>
Co-authored-by: Samuel Dion-Girardeau <samueldg@users.noreply.github.com>
Doris-Ge added a commit that referenced this pull request Jun 9, 2023
…h send (#706)

* Implement `send_each` and `send_each_for_multicast` (#692)

`send_each` vs `send_all`
1. `send_each` sends one HTTP request to V1 Send endpoint for each message in the list. `send_all` sends only one HTTP request to V1 Batch Send endpoint to send all messages in the array.
2. `send_each` uses concurrent.futures.ThreadPoolExecutor to run and wait for all `request` calls to complete and construct a `BatchResponse`. An `request` call to V1 Send endpoint either completes with a success or throws an exception. So if an exception is thrown out, the exception will be caught in `send_each` and turned into a `SendResponse` with an exception. Therefore, unlike `send_all`, `send_each` does not always throw an exception for a total failure. It can also return a `BatchResponse` with only exceptions in it.

`send_each_for_multicast` calls `send_each` under the hood.

* Add integration tests for send_each and send_each_for_multicast (#700)

* Add integration tests for send_each and send_each_for_multicast

Add test_send_each, test_send_each_500 and test_send_each_for_multicast

* chore: Fix pypy tests (#694)

* chore(auth): Update Auth API to `v2` (#691)

* `v2beta1` -> `v2`

* Reverting auto formatting changes

* undo auto formatting

* Add release notes to project URLs in PyPI (#679)

It's useful to be able to navigate to the release notes easily
from the package index when upgrading.

"Release Notes" is a special keyword that will have the scroll icon
in the project page.

A random example:

* https://pypi.org/project/streamlit/
* https://github.com/streamlit/streamlit/blob/815a3ea6fa3e7f9099b479e8365bd3a5874ddc35/lib/setup.py#L111

Co-authored-by: Lahiru Maramba <llahiru@gmail.com>

---------

Co-authored-by: Lahiru Maramba <llahiru@gmail.com>
Co-authored-by: pragatimodi <110490169+pragatimodi@users.noreply.github.com>
Co-authored-by: Samuel Dion-Girardeau <samueldg@users.noreply.github.com>

---------

Co-authored-by: Lahiru Maramba <llahiru@gmail.com>
Co-authored-by: pragatimodi <110490169+pragatimodi@users.noreply.github.com>
Co-authored-by: Samuel Dion-Girardeau <samueldg@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants