Skip to content

chore: Correct x-goog-api-client header logic #876

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

chore: Correct x-goog-api-client header logic #876

merged 1 commit into from
May 8, 2025

Conversation

jonathanedey
Copy link
Contributor

  • Lower cased x-goog-api-client
  • Moved x-goog-api-client to be applied on request rather that on session
  • Fixed tests to simulate x-goog-api-client mutation by AuthorizedSession

@jonathanedey jonathanedey added the release:stage Stage a release candidate label May 1, 2025
@jonathanedey jonathanedey requested a review from lahirumaramba May 2, 2025 13:58
lahirumaramba
lahirumaramba approved these changes May 8, 2025
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix! LGTM!

@lahirumaramba lahirumaramba merged commit 70013c8 into master May 8, 2025
19 of 20 checks passed
@lahirumaramba lahirumaramba deleted the je-fix-metrics branch May 8, 2025 18:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees

@lahirumaramba lahirumaramba

Labels
release:stage Stage a release candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanedey @lahirumaramba