Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add try catch block unregistering ConnectivityChangeReceiver #6560

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lehcar09
Copy link
Contributor

@lehcar09 lehcar09 commented Dec 4, 2024

Add try catch block for possible race condition when unregistering the ConnectivityChangeReceiver

Issue: #6558

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-messaging

    TypeBase (801bf4d)Merge (c043ff2)Diff
    aar149 kB149 kB+47 B (+0.0%)
    apk (aggressive)578 kB578 kB+16 B (+0.0%)
    apk (release)5.30 MB5.30 MB+16 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qmjNcTnexm.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-messaging

    Overall coverage changed from 84.19% (801bf4d) to 84.13% (c043ff2) by -0.06%.

    FilenameBase (801bf4d)Merge (c043ff2)Diff
    SyncTask.java70.83%68.92%-1.91%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/K9zVdXRDn0.html

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Test Results

 64 files   -    972   64 suites   - 972   6m 18s ⏱️ - 26m 26s
487 tests  -  5 386  487 ✅  -  5 364  0 💤  - 22  0 ❌ ±0 
980 runs   - 10 851  980 ✅  - 10 807  0 💤  - 44  0 ❌ ±0 

Results for commit 4e5bfc5. ± Comparison against base commit 801bf4d.

This pull request removes 5386 tests.
com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldAddCookieOnPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldDropCookieOnMixedPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost
…

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants