Skip to content

Create SharedSessionRepository and remove bound service #6844

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

Create SharedSessionRepository and remove bound service #6844

merged 2 commits into from
Apr 9, 2025

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Apr 8, 2025 •
edited
Loading

This removes all the bound service implementation, and starts the shared sessions repository implementation. The shared repository is responsible for sharing session data between processes in a simple way.

This does not detect cold starts yet. The SharedSessionRepository class might be getting too much, we will consider splitting it up as implementation goes further.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 8, 2025 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (20a4864) to 80.00% (e422233) by ?.

    45 individual files with coverage change

    FilenameBase (20a4864)Merge (e422233)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    DaggerFirebaseSessionsComponent.java?94.12%?
    EventGDTLogger.kt?70.00%?
    EventGDTLogger_Factory.java?0.00%?
    FirebaseSessions.kt?62.50%?
    FirebaseSessionsComponent.kt?65.79%?
    FirebaseSessionsComponent_MainModule_Companion_ApplicationInfoFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_SessionConfigsDataStoreFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_SessionDataStoreFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_TimeProviderFactory.java?100.00%?
    FirebaseSessionsComponent_MainModule_Companion_UuidGeneratorFactory.java?100.00%?
    FirebaseSessionsDependencies.kt?85.71%?
    FirebaseSessionsRegistrar.kt?90.91%?
    FirebaseSessions_Factory.java?0.00%?
    InstallationId.kt?100.00%?
    LocalOverrideSettings.kt?100.00%?
    LocalOverrideSettings_Factory.java?0.00%?
    ProcessDetailsProvider.kt?76.67%?
    RemoteSettings.kt?88.41%?
    RemoteSettingsFetcher.kt?10.00%?
    RemoteSettingsFetcher_Factory.java?0.00%?
    RemoteSettings_Factory.java?0.00%?
    SessionConfigs.kt?95.45%?
    SessionData.kt?58.82%?
    SessionDataSerializer_Factory.java?0.00%?
    SessionDetails.kt?85.71%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?98.00%?
    SessionFirelogPublisher.kt?81.58%?
    SessionFirelogPublisherImpl_Factory.java?0.00%?
    SessionGenerator.kt?100.00%?
    SessionGenerator_Factory.java?0.00%?
    SessionsActivityLifecycleCallbacks.kt?22.22%?
    SessionsActivityLifecycleCallbacks_Factory.java?0.00%?
    SessionsSettings.kt?93.75%?
    SessionsSettings_Factory.java?0.00%?
    SessionSubscriber.kt?75.00%?
    SettingsCache.kt?80.56%?
    SettingsCacheImpl_Factory.java?0.00%?
    SettingsProvider.kt?50.00%?
    SharedSessionRepository.kt?34.04%?
    SharedSessionRepositoryImpl_Factory.java?0.00%?
    TimeProvider.kt?62.50%?
    UuidGenerator.kt?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vgpHjBAoqN.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025 •
edited
Loading

Test Results

 32 files   32 suites   45s ⏱️
 68 tests  68 ✅ 0 💤 0 ❌
136 runs  136 ✅ 0 💤 0 ❌

Results for commit eb3faa2.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 8, 2025 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (20a4864)Merge (e422233)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)

  • firebase-sessions

    TypeBase (20a4864)Merge (e422233)Diff
    aar?195 kB? (?)
    apk (aggressive)?535 kB? (?)
    apk (release)?5.77 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/QrY8qG5LUf.html

@mrober mrober requested review from tejasd and themiswang April 8, 2025 15:09
@mrober mrober marked this pull request as ready for review April 8, 2025 15:12
@mrober mrober merged commit 2b1e056 into sessions-sharedrepo Apr 9, 2025
30 of 31 checks passed
@mrober mrober deleted the mrober/sharedrepo branch April 9, 2025 14:43
mrober added a commit that referenced this pull request Apr 15, 2025
@mrober
Create SharedSessionRepository and remove bound service (#6844)
2182ce7 
This removes all the bound service implementation, and starts the shared
sessions repository implementation. The shared repository is responsible
for sharing session data between processes in a simple way.

This does not detect cold starts yet. The `SharedSessionRepository`
class might be getting too much, we will consider splitting it up as
implementation goes further.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tejasd tejasd tejasd approved these changes

@themiswang themiswang themiswang approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrober @google-oss-bot @tejasd @themiswang