Skip to content

Adjust Metalava SemVer task #6846

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 7 commits into from
Apr 10, 2025
Merged

Adjust Metalava SemVer task #6846

merged 7 commits into from
Apr 10, 2025

Conversation

emilypgoogle
Copy link
Collaborator

@emilypgoogle emilypgoogle commented Apr 8, 2025

Reverses the order in which branches and comparisons are done. This will mean the actual test behavior lags behind by one commit, so to test this I will open a PR to this branch not to be merged with example changes.

See test success here #6849

Copy link
Contributor

github-actions bot commented Apr 8, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

github-actions bot commented Apr 8, 2025

Test Results

 1 034 files  +   992   1 034 suites  +992   34m 23s ⏱️ + 33m 0s
 5 874 tests + 5 550   5 852 ✅ + 5 528  22 💤 +22  0 ❌ ±0 
11 811 runs  +11 151  11 767 ✅ +11 107  44 💤 +44  0 ❌ ±0 

Results for commit 6be5158. ± Comparison against base commit 5081e7c.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 8, 2025

Coverage Report 1

Affected Products

  • firebase-messaging

    Overall coverage changed from 84.13% (d7a56a1) to 84.02% (8b53375) by -0.11%.

    FilenameBase (d7a56a1)Merge (8b53375)Diff
    Metadata.java41.27%36.51%-4.76%
  • firebase-ml-modeldownloader

    Overall coverage changed from 82.04% (d7a56a1) to 82.11% (8b53375) by +0.06%.

    FilenameBase (d7a56a1)Merge (8b53375)Diff
    FirebaseModelDownloader.java84.05%84.66%+0.61%
  • firebase-database

    FilenameBase (d7a56a1)Merge (8b53375)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%
    DoubleNode.java100.00%88.24%-11.76%
    ViewProcessor.java92.10%91.79%-0.30%
    WriteTree.java77.22%76.67%-0.56%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/tdWpK7K5Gm.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 8, 2025

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 8, 2025

Startup Time Report 1

The report is too large (122,594 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/lEQ1ELqjMO/index.html

Copy link
Contributor

github-actions bot commented Apr 8, 2025

plugins test results

68 tests   68 ✅  1m 10s ⏱️
12 suites   0 💤
12 files     0 ❌

Results for commit 6be5158.

♻️ This comment has been updated with latest results.

@emilypgoogle emilypgoogle requested a review from rlazo April 8, 2025 21:22
@rlazo rlazo requested a review from daymxn April 9, 2025 16:42
@emilypgoogle emilypgoogle requested review from rlazo and daymxn April 9, 2025 21:56
@emilypgoogle emilypgoogle merged commit 3b7e1e4 into main Apr 10, 2025
258 of 263 checks passed
@emilypgoogle emilypgoogle deleted the ep/metalava-semver-fix branch April 10, 2025 16:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants