Skip to content

semaphore_test.cc: re-enable MultithreadedStressTest #1036

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

dconeybe
Copy link
Contributor

With the fix to Semaphore::TimedWait() in #1021, the MultithreadedStressTest can now be re-enabled.

@dconeybe dconeybe added the skip-release-notes Skip release notes check label Jul 20, 2022
@dconeybe dconeybe self-assigned this Jul 20, 2022
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label Jul 20, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 20, 2022
@github-actions
Copy link

github-actions bot commented Jul 20, 2022

✅  Integration test succeeded!

Requested by @dconeybe on commit 63e6549
Last updated: Thu Jul 21 14:11 PDT 2022
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jul 20, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 20, 2022
@dconeybe dconeybe requested a review from jonsimantov July 20, 2022 17:04
@dconeybe dconeybe merged commit 63e6549 into main Jul 21, 2022
@dconeybe dconeybe deleted the dconeybe/SemaphoreTestReEnableSemaphoreMultithreadedStressTest branch July 21, 2022 18:19
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Jul 21, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 21, 2022
@firebase firebase locked and limited conversation to collaborators Aug 21, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants