Skip to content

Disable getSessionId test on emulators. #1193

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2023
Merged

Disable getSessionId test on emulators. #1193

merged 2 commits into from
Jan 30, 2023

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added tests-requested: quick Trigger a quick set of integration tests. skip-release-notes Skip release notes check labels Jan 25, 2023
@jonsimantov jonsimantov requested a review from a-maurice January 25, 2023 23:19
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jan 25, 2023
@github-actions
Copy link

github-actions bot commented Jan 25, 2023 •
edited
Loading

❌  Integration test FAILED

Requested by @jonsimantov on commit 0d93bad
Last updated: Mon Jan 30 15:17 PST 2023
View integration test log & download artifacts

Failures Configs
analytics [BUILD] [ERROR] [Linux] [x64] [openssl]
[BUILD] [ERROR] [MacOS] [x64] [openssl]
[BUILD] [ERROR] [Windows] [x64] [openssl]

Add flaky tests to go/fpl-cpp-flake-tracker

@jonsimantov jonsimantov enabled auto-merge (squash) January 25, 2023 23:35
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jan 26, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 26, 2023
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jan 30, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Jan 30, 2023
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jan 30, 2023
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jan 30, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 30, 2023
@jonsimantov jonsimantov changed the title Disable getSessionId test on Android emulator. Disable getSessionId test on emulators. Jan 30, 2023
@jonsimantov jonsimantov disabled auto-merge January 30, 2023 22:02
@jonsimantov jonsimantov merged commit 0d93bad into main Jan 30, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels Jan 30, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 30, 2023
@firebase firebase locked and limited conversation to collaborators Mar 2, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@a-maurice a-maurice a-maurice approved these changes

Assignees

@a-maurice a-maurice

Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @a-maurice