Skip to content

Firestore COUNT #1207

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 11 commits into from
Apr 5, 2023
Merged

Firestore COUNT #1207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
bb236fc
Firestore COUNT API (#1174)
tom-andersen Feb 10, 2023
cf18ec7
Tomandersen/count test (#1206)
tom-andersen Mar 6, 2023
3a66552
PR Followup (#1237)
tom-andersen Mar 16, 2023
f51eeec
Tomandersen/count api (#1236)
tom-andersen Mar 20, 2023
ae48d8c
Merge branch 'main' into count
tom-andersen Mar 20, 2023
fa81ff9
Fix
tom-andersen Mar 23, 2023
01f9e31
Merge remote-tracking branch 'origin/main' into count
tom-andersen Mar 31, 2023
9d88ffe
Revert Query Test changes.
tom-andersen Apr 3, 2023
e6c018c
Add separate file for count tests.
tom-andersen Apr 3, 2023
9a747b5
Changes from PR comments
tom-andersen Apr 3, 2023
378a898
Pretty
tom-andersen Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ gcs_key_file.json

# Folders for cmake/test output
*_build/
*cmake-build-debug/
cmake-build-*/
testing/test_framework/external/

# XCode user specific folders
Expand Down
3 changes: 3 additions & 0 deletions app/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,9 @@ if (IOS)
${FIREBASE_SOURCE_DIR}/dynamic_links/src/include/firebase/dynamic_links/components.h)
set(firestore_HDRS
${FIREBASE_SOURCE_DIR}/firestore/src/include/firebase/firestore.h
${FIREBASE_SOURCE_DIR}/firestore/src/include/firebase/firestore/aggregate_query.h
${FIREBASE_SOURCE_DIR}/firestore/src/include/firebase/firestore/aggregate_query_snapshot.h
${FIREBASE_SOURCE_DIR}/firestore/src/include/firebase/firestore/aggregate_source.h
${FIREBASE_SOURCE_DIR}/firestore/src/include/firebase/firestore/collection_reference.h
${FIREBASE_SOURCE_DIR}/firestore/src/include/firebase/firestore/document_change.h
${FIREBASE_SOURCE_DIR}/firestore/src/include/firebase/firestore/document_reference.h
Expand Down
12 changes: 12 additions & 0 deletions firestore/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ else()
endif()

set(common_SRCS
src/common/aggregate_query.cc
src/common/aggregate_query_snapshot.cc
src/common/cleanup.h
src/common/collection_reference.cc
src/common/compiler_info.cc
Expand Down Expand Up @@ -65,6 +67,12 @@ binary_to_array("firestore_resources"

set(android_SRCS
${firestore_resources_source}
src/android/aggregate_query_android.cc
src/android/aggregate_query_android.h
src/android/aggregate_query_snapshot_android.cc
src/android/aggregate_query_snapshot_android.h
src/android/aggregate_source_android.cc
src/android/aggregate_source_android.h
src/android/blob_android.cc
src/android/blob_android.h
src/android/collection_reference_android.cc
Expand Down Expand Up @@ -185,6 +193,10 @@ set(android_SRCS

# Sources that apply to all non-Android platforms.
set(main_SRCS
src/main/aggregate_query_main.cc
src/main/aggregate_query_main.h
src/main/aggregate_query_snapshot_main.cc
src/main/aggregate_query_snapshot_main.h
src/main/collection_reference_main.cc
src/main/collection_reference_main.h
src/main/converter_main.h
Expand Down
2 changes: 1 addition & 1 deletion firestore/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ a Python3 installation.

# Architecture

It is easier to work this Firestore CPP SDK by keeping a high level archetecture in mind:
It is easier to work this Firestore CPP SDK by keeping a high level architecture in mind:

![architecture.png](architecture.png)

Expand Down
2 changes: 2 additions & 0 deletions firestore/integration_test_internal/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ set(FIREBASE_INTEGRATION_TEST_PORTABLE_TEST_SRCS
# public API are performed.
src/integration_test.cc
# Internal tests below.
src/aggregate_query_snapshot_test.cc
src/aggregate_query_test.cc
src/bundle_test.cc
src/collection_reference_test.cc
src/cursor_test.cc
Expand Down
Loading