-
Notifications
You must be signed in to change notification settings - Fork 122
add UseEmulator api to auth #1437
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
352ba83
add auth emulator support
6ccf941
fix ios number parse
b1a8d27
update the documentation part
64fd592
reduce lint warning
4d012dc
more lint warnings
ce63a9e
code format
1e1a9ce
use environment to decide using emulator or not
14ebb5d
fix a typo
62d5c3f
Merge branch 'main' into cj_rest
cynthiajoan c2e952a
add readme entry for FirebaseApp.GetApps()
90f2f2d
Merge branch 'main' into cj_rest
cynthiajoan 9e5c7a8
update for review comment
79ee455
add missing `
26547d6
Merge branch 'main' into cj_rest
cynthiajoan 472fbb3
make json request always do restrict json
c459351
Merge https://github.com/firebase/firebase-cpp-sdk into cj_rest
5dfcd36
add readme info
49ca0fc
Merge branch 'cj_rest' of https://github.com/firebase/firebase-cpp-sd…
f3894bf
prepare for review
e6c7bdb
some minor tweak
e08a598
code format
fee091a
update review comments
ac867c1
update the unit test after request json change
2d7a50d
remove platform logging v1 code
9b1492a
Merge https://github.com/firebase/firebase-cpp-sdk into cj_rest
bb40854
add useEmulator api
13196a7
test with emulator
e4887cb
clean up for review
b07e0ce
tweak for review
7f510ae
update with comments
cd3c0ef
put back necessary heartbeat blocks
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing the user_agent stuff should not be getting removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I consulted with Shawn and they are actually not needed anymore. Include Shawn to review to confirm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the user-agent stuffs are not used, at least by Platform Logging pipeline, at all, except for the section I commented below. Therefore it is safe to remove.
However, I wonder if this should be in this particular PR.
If you are planning to bundle this change along with emulator support, please make sure you include this information in the commit message, so it does not look like an accident change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done