Add support for an authPolicy that returns Permission Denied when failed #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeold
approved these changes
Dec 13, 2024
package-lock.json
Outdated
There was a problem hiding this comment.
was checking in package-lock intentional? I don't see a change in package.json?
There was a problem hiding this comment.
Yes. I couldn't successfully compile until I ran npm install and that changed package-lock.json
src/common/providers/https.ts
Outdated
| @@ -841,6 +842,14 @@ function wrapOnCallHandler<Req = any, Res = any>( | |||
| } | |||
|
|
|||
| const data: Req = decode(req.body.data); | |||
| if (options.authPolicy) { | |||
| // Don't ask me why, but Google decided not to disambiguate between unauthenticated and unauthorized | |||
There was a problem hiding this comment.
is this true? we have permission-denied and unauthenticated:
https://github.com/grpc/grpc/blob/master/doc/statuscodes.md
There was a problem hiding this comment.
I wrote this comment before I realized better. Will delete the comment.
Berlioz
pushed a commit
that referenced
this pull request
Dec 19, 2024
…led (#1650) * Add support for an authPolicy that returns Permission Denied when failed * Formatter * Changelog * remove ignorant comment
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
…n top-level awaits (#1651) * Use await import instead of require for functions modules that contain top-level awaits * tests ensuring that es modules with top level awaits can be loaded * adds node 22 to the CI matrix on github * Add support for an authPolicy that returns Permission Denied when failed (#1650) * Add support for an authPolicy that returns Permission Denied when failed * Formatter * Changelog * remove ignorant comment * Update streaming callable API (#1652) * Update streaming callable API * Fix linter error * Stream type defaults to unknown * Changelog * Format fix * update changelog.md --------- Co-authored-by: Thomas Bouldin <inlined@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per upcoming design (and to support
onCallGenkitcallable functions' options can now support anauthPolicycallback. Adds support for this callback, as well as two helpers:isSignedInandhasClaim.