Skip to content

fix(logger): no longer detects duplicate object as circular #1679

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Apr 4, 2025

Conversation

CorieW
Copy link
Contributor

@CorieW CorieW commented Mar 11, 2025

Resolves #1510

@CorieW CorieW force-pushed the @invertase/fix-logger-circular-removal branch from 7d2dcf2 to 0cbbf47 Compare March 11, 2025 14:50
@CorieW CorieW force-pushed the @invertase/fix-logger-circular-removal branch from 0cbbf47 to 2e6bc64 Compare March 11, 2025 14:54
@CorieW CorieW requested a review from cabljac March 11, 2025 15:05
Copy link

@cabljac cabljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm, couple of questions though

@CorieW CorieW force-pushed the @invertase/fix-logger-circular-removal branch from fce1dc5 to cf2cb4d Compare March 19, 2025 13:15
Copy link

@cabljac cabljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link

@cabljac cabljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@CorieW CorieW added this pull request to the merge queue Apr 4, 2025
Merged via the queue into master with commit 4559866 Apr 4, 2025
17 checks passed
@cabljac cabljac deleted the @invertase/fix-logger-circular-removal branch April 4, 2025 10:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
3 participants