Skip to content

Fix CI breakage from recent merge #12504

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2024
Merged

Fix CI breakage from recent merge #12504

merged 1 commit into from
Mar 9, 2024

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Mar 9, 2024

#12498 merged with trailing whitespace. fixing here.

@jonsimantov
Copy link
Contributor

The patch file format may actually require the trailing whitespace. Let me try a build against this branch to double check.

@jonsimantov
Copy link
Contributor

The patch file format may actually require the trailing whitespace. Let me try a build against this branch to double check.

OK, looks like it still works. 👍

@paulb777 paulb777 merged commit d715ee8 into main Mar 9, 2024
@paulb777 paulb777 deleted the pb-fix-ci branch March 9, 2024 02:17
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.15% (6ae867d) to 88.08% (94c9296) by -0.07%.

    FilenameBase (6ae867d)Merge (94c9296)Diff
    exception.cc84.21%23.68%-60.53%
    leveldb_key.cc98.14%98.82%+0.69%
    leveldb_remote_document_cache.cc96.55%94.83%-1.72%
    task.cc94.78%93.91%-0.87%
    write_stream.cc91.55%94.37%+2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/fxw1fDHzyW.html

@firebase firebase locked and limited conversation to collaborators Apr 9, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@jonsimantov jonsimantov jonsimantov approved these changes

@themiswang themiswang themiswang approved these changes

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paulb777 @jonsimantov @google-oss-bot @themiswang @ncooke3