Skip to content

[Release] Re-spin FST with signed artifact #12549

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Mar 13, 2024
Merged

[Release] Re-spin FST with signed artifact #12549

merged 3 commits into from
Mar 13, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Mar 13, 2024

#no-changelog

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@ncooke3
Copy link
Member Author

ncooke3 commented Mar 13, 2024

 Downloads 
‣ diff -r /Users/nickcooke/Downloads/FirebaseFirestoreInternal.xcframework  /Users/nickcooke/Downloads/FirebaseFirestoreInternal_old.xcframework                                   
Only in /Users/nickcooke/Downloads/FirebaseFirestoreInternal.xcframework: _CodeSignature

@ncooke3
Copy link
Member Author

ncooke3 commented Mar 13, 2024

I don't think there is an issue but making a note here...

This is the build log that seems to confirm it is picking up a signature. Unfortunately, I cannot double click into the "Show Signature Information" part. Xcode 15.3 RC doesn't do anything when you double click that.
Screenshot 2024-03-13 at 6 54 42 PM

But, I manually dragged in the xcframework and you can see the signature pick up:
Screenshot 2024-03-13 at 6 54 27 PM

@ncooke3
Copy link
Member Author

ncooke3 commented Mar 13, 2024

Pointing to this branch, I built my test app for iOS and also for macOS. Both archives validated successfully. This is gtg on green.

@ncooke3
Copy link
Member Author

ncooke3 commented Mar 13, 2024

@paulb777, despite the failing CI, think this can still merge. WDYT? I've never seen these failures before but they are mainly FirebasweFunctions integration tests.

@paulb777
Copy link
Member

SGTM - I would think any signing issues would show up at build time - not runtime.

@paulb777
Copy link
Member

I'll merge and retag now.

@paulb777 paulb777 merged commit fcf5ced into main Mar 13, 2024
@paulb777 paulb777 deleted the nc/respin-signed branch March 13, 2024 23:36
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager Apr 9, 2024
….23.1" (#948)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[firebase/firebase-ios-sdk](https://github.com/firebase/firebase-ios-sdk)
| minor | `from: "10.21.0"` -> `from: "10.23.1"` |

---

### Release Notes

<details>
<summary>firebase/firebase-ios-sdk (firebase/firebase-ios-sdk)</summary>

###
[`v10.23.1`](https://github.com/firebase/firebase-ios-sdk/releases/tag/10.23.1)

[Compare
Source](https://github.com/firebase/firebase-ios-sdk/compare/10.23.0...10.23.1)

The Firebase Apple SDK (10.23.1) is now available.

This release is only available for CocoaPods and Swift Package Manager
and only changes Firebase Analytics.

See details at [Firebase Apple SDK release
notes.](https://firebase.google.com/support/release-notes/ios#10.23.1)

#### What's Changed

- \[Release] Update Package.swift for 10.23.1 patch by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12644](https://github.com/firebase/firebase-ios-sdk/pull/12644)
- Analytics 10.23.1 by [@&#8203;htcgh](https://github.com/htcgh) in
[https://github.com/firebase/firebase-ios-sdk/pull/12648](https://github.com/firebase/firebase-ios-sdk/pull/12648)
- 10.23.1 podspec updates by
[@&#8203;paulb777](https://github.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12647](https://github.com/firebase/firebase-ios-sdk/pull/12647)
- Tweak release note by
[@&#8203;paulb777](https://github.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12649](https://github.com/firebase/firebase-ios-sdk/pull/12649)

**Full Changelog**:
firebase/firebase-ios-sdk@10.23.0...10.23.1

###
[`v10.23.0`](https://github.com/firebase/firebase-ios-sdk/releases/tag/10.23.0)

[Compare
Source](https://github.com/firebase/firebase-ios-sdk/compare/10.22.1...10.23.0)

The Firebase Apple SDK (10.23.0) is now available. For more details, see
the [Firebase Apple SDK release
notes.](https://firebase.google.com/support/release-notes/ios#10.23.0)

To install this SDK, see [Add Firebase to your
project.](https://firebase.google.com/docs/ios/setup)

#### What's Changed

- \[Release] Update versions for Release 10.23.0 by
[@&#8203;andrewheard](https://github.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/12467](https://github.com/firebase/firebase-ios-sdk/pull/12467)
- Add API tests for hashed email and phone number by
[@&#8203;tsunghung](https://github.com/tsunghung) in
[https://github.com/firebase/firebase-ios-sdk/pull/12469](https://github.com/firebase/firebase-ios-sdk/pull/12469)
- Update upload-symbols to 13.7 by
[@&#8203;themiswang](https://github.com/themiswang) in
[https://github.com/firebase/firebase-ios-sdk/pull/12471](https://github.com/firebase/firebase-ios-sdk/pull/12471)
- Analytics 10.22.1 by
[@&#8203;tsunghung](https://github.com/tsunghung) in
[https://github.com/firebase/firebase-ios-sdk/pull/12482](https://github.com/firebase/firebase-ios-sdk/pull/12482)
- Upgrade `clang-format` to v18 by
[@&#8203;andrewheard](https://github.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/12483](https://github.com/firebase/firebase-ios-sdk/pull/12483)
- \[Release] Add patch note for 10.22.1 by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12490](https://github.com/firebase/firebase-ios-sdk/pull/12490)
- Restore 10.23.0 versions to main after 10.22.1 by
[@&#8203;paulb777](https://github.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12497](https://github.com/firebase/firebase-ios-sdk/pull/12497)
- Patch abseil-cpp to ignore deprecated errors in new Xcode. by
[@&#8203;jonsimantov](https://github.com/jonsimantov) in
[https://github.com/firebase/firebase-ios-sdk/pull/12498](https://github.com/firebase/firebase-ios-sdk/pull/12498)
- Fix CI breakage from recent merge by
[@&#8203;paulb777](https://github.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12504](https://github.com/firebase/firebase-ios-sdk/pull/12504)
- Resolved warning no rule to process file 'PrivacyInfo.xcprivacy' of
type 'text.xml' with CocoaPods by
[@&#8203;HikaruSato](https://github.com/HikaruSato) in
[https://github.com/firebase/firebase-ios-sdk/pull/12513](https://github.com/firebase/firebase-ios-sdk/pull/12513)
- Upgrade grpc to 1.62 for cocoapods by
[@&#8203;wu-hui](https://github.com/wu-hui) in
[https://github.com/firebase/firebase-ios-sdk/pull/12398](https://github.com/firebase/firebase-ios-sdk/pull/12398)
- Snapshot listener source from cache by
[@&#8203;milaGGL](https://github.com/milaGGL) in
[https://github.com/firebase/firebase-ios-sdk/pull/12370](https://github.com/firebase/firebase-ios-sdk/pull/12370)
- \[Rollouts] Feature rollouts merge to main by
[@&#8203;themiswang](https://github.com/themiswang) in
[https://github.com/firebase/firebase-ios-sdk/pull/12410](https://github.com/firebase/firebase-ios-sdk/pull/12410)
- \[spm] Update grpc to 1.62.3 by
[@&#8203;paulb777](https://github.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12520](https://github.com/firebase/firebase-ios-sdk/pull/12520)
- \[Release Tooling] Copy over macOS/macCatalyst plists by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12517](https://github.com/firebase/firebase-ios-sdk/pull/12517)
- NOTICES Change by
[@&#8203;github-actions](https://github.com/github-actions) in
[https://github.com/firebase/firebase-ios-sdk/pull/12524](https://github.com/firebase/firebase-ios-sdk/pull/12524)
- Changelog updates for 10.23.0 by
[@&#8203;paulb777](https://github.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12533](https://github.com/firebase/firebase-ios-sdk/pull/12533)
- \[Firestore] Improve logging in scripts/check_firestore_symbols.sh by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12535](https://github.com/firebase/firebase-ios-sdk/pull/12535)
- \[Firestore] Add unlinked symbol introduced in
[#&#8203;12370](https://github.com/firebase/firebase-ios-sdk/issues/12370)
by [@&#8203;ncooke3](https://github.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12534](https://github.com/firebase/firebase-ios-sdk/pull/12534)
- \[Firestore] Re-export public header added in
[#&#8203;12370](https://github.com/firebase/firebase-ios-sdk/issues/12370)
by [@&#8203;ncooke3](https://github.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12537](https://github.com/firebase/firebase-ios-sdk/pull/12537)
- \[Firestore] Bump dependency ranges for Firestore's binary SPM distro
by [@&#8203;ncooke3](https://github.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12538](https://github.com/firebase/firebase-ios-sdk/pull/12538)
- Fix Firestore build warnings by
[@&#8203;cherylEnkidu](https://github.com/cherylEnkidu) in
[https://github.com/firebase/firebase-ios-sdk/pull/12536](https://github.com/firebase/firebase-ios-sdk/pull/12536)
- Analytics 10.23.0 by [@&#8203;htcgh](https://github.com/htcgh) in
[https://github.com/firebase/firebase-ios-sdk/pull/12539](https://github.com/firebase/firebase-ios-sdk/pull/12539)
- \[Release] Update FirebaseFirestoreInternal checksum by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12545](https://github.com/firebase/firebase-ios-sdk/pull/12545)
- \[Release] Re-spin FST with signed artifact by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12549](https://github.com/firebase/firebase-ios-sdk/pull/12549)

#### New Contributors

- [@&#8203;HikaruSato](https://github.com/HikaruSato) made their first
contribution in
[https://github.com/firebase/firebase-ios-sdk/pull/12513](https://github.com/firebase/firebase-ios-sdk/pull/12513)

**Full Changelog**:
firebase/firebase-ios-sdk@10.22.1...10.23.0

###
[`v10.22.1`](https://github.com/firebase/firebase-ios-sdk/releases/tag/10.22.1):
Firebase Apple 10.22.1

[Compare
Source](https://github.com/firebase/firebase-ios-sdk/compare/10.22.0...10.22.1)

The Firebase Apple SDK (10.22.1) is now available. For more details, see
the [Firebase Apple SDK release
notes.](https://firebase.google.com/support/release-notes/ios#10.22.1)

To install this SDK, see [Add Firebase to your
project.](https://firebase.google.com/docs/ios/setup)

###
[`v10.22.0`](https://github.com/firebase/firebase-ios-sdk/releases/tag/10.22.0):
Firebase Apple 10.22.0

[Compare
Source](https://github.com/firebase/firebase-ios-sdk/compare/10.21.0...10.22.0)

The Firebase Apple SDK (10.22.0) is now available. For more details, see
the [Firebase Apple SDK release
notes](https://firebase.google.com/support/release-notes/ios#10.22.0).

To install this SDK, see [Add Firebase to your
project](https://firebase.google.com/docs/ios/setup).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
@firebase firebase locked and limited conversation to collaborators Apr 13, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants