Skip to content

[Vertex AI] Update log message when API is not enabled #13733

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Sep 27, 2024

  • Updated the the log message when firebasevertexai.googleapis.com is not enabled to direct developers solely to the Firebase Console.
  • In DEBUG builds, this situation is now a fatalError instead of an error log. This will quickly alert developers to the problem during development.
    • To avoid crashing released apps, the message remains an error log in release builds.
    • fatalError approach breaks unit tests, always log at the error level.

#no-changelog

@andrewheard andrewheard changed the base branch from vertexai-release to main September 30, 2024 14:32
@andrewheard andrewheard merged commit a14a2c5 into main Sep 30, 2024
49 checks passed
@andrewheard andrewheard deleted the ah/vertexai-api-log branch September 30, 2024 17:05
@firebase firebase locked and limited conversation to collaborators Oct 31, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants