Skip to content

[Vertex AI] Remove NSObject superclass from VertexAI #13742

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2024
Merged

[Vertex AI] Remove NSObject superclass from VertexAI #13742

merged 1 commit into from
Sep 30, 2024

Conversation

andrewheard
Copy link
Contributor

Removed the NSObject superclass from VertexAI since the SDK is available in Swift only.

#no-changelog

@andrewheard andrewheard added this to the 11.4.0 - M155 milestone Sep 30, 2024
ncooke3
ncooke3 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that this does not interfere with FIRVertexAIComponent's registration with ObjC runtime.

@andrewheard andrewheard merged commit 533061f into main Sep 30, 2024
38 checks passed
@andrewheard andrewheard deleted the ah/vertex-nsobject branch September 30, 2024 21:20
@github-actions github-actions bot mentioned this pull request Oct 22, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Oct 31, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
api: vertexai
Projects
None yet
Milestone
11.4.0 - M155
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewheard @ncooke3 @google-oss-bot