Skip to content

[Vertex AI] Fix caching of Vertex AI instances #14007

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Oct 31, 2024

Instances are now cached by the the Firebase App name and the Vertex AI location. Previously Vertex AI instances were re-used if the location matched, even if they were intended for different Firebase Apps.

@andrewheard andrewheard marked this pull request as ready for review October 31, 2024 21:38
@andrewheard andrewheard requested a review from paulb777 October 31, 2024 21:38
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@andrewheard andrewheard merged commit 33a44a9 into main Oct 31, 2024
38 checks passed
@andrewheard andrewheard deleted the ah/vertex-instances-fix branch October 31, 2024 21:59
@firebase firebase locked and limited conversation to collaborators Dec 1, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants