Skip to content

[Release] Add FirebaseCombineSwift to FirebaseManifest #14110

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Nov 13, 2024

Added the FirebaseCombineSwift pod to the FirebaseManifest but specified as releasing: false, zip: false. Updated the Pod initializer to store podVersion if specified (previously ignored) and updated Manifest.versionString(_:) to use the podVersion (was intended for including FirebaseAuthTestingSupport and FirebaseFirestoreTestingSupport in the Manifest but not needed).

Note: The combine workflow is currently failing (#14106) because the release tooling did not update its dependency on FirebaseCore to the new version in #14104 and the version requirements are now stricter.

#no-changelog

@andrewheard andrewheard marked this pull request as ready for review November 13, 2024 21:33
@andrewheard andrewheard requested a review from paulb777 November 13, 2024 21:33
@andrewheard andrewheard merged commit d3f686c into main Nov 13, 2024
73 checks passed
@andrewheard andrewheard deleted the version-11.6 branch November 13, 2024 23:27
@firebase firebase locked and limited conversation to collaborators Dec 14, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants