Skip to content

[Auth] Remove unnecessary throws on internal methods #14154

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2024
Merged

[Auth] Remove unnecessary throws on internal methods #14154

merged 2 commits into from
Nov 20, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Nov 20, 2024

Methods don't throw, so remove the throws keyword.

#no-changelog

@ncooke3 ncooke3 requested a review from paulb777 November 20, 2024 22:05
@ncooke3 ncooke3 merged commit cb0bc77 into main Nov 20, 2024
55 checks passed
@ncooke3 ncooke3 deleted the nc/unused-throw branch November 20, 2024 22:38
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Dec 21, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncooke3 @paulb777 @google-oss-bot