Skip to content

[Firestore] Add conditonal Sendability conformance to ServerTimestamp #14162

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Nov 22, 2024

Fix #14042

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Apple API Diff Report

Commit: 29963c4
Last updated: Fri Nov 22 09:47 PST 2024
View workflow logs & download artifacts


[BUILD ERROR] FirebaseFirestore


@ncooke3 ncooke3 requested a review from andrewheard November 22, 2024 17:33
@ncooke3 ncooke3 changed the title [Auth] Add conditonal Sendability conformance to ServerTimestamp [Firestore] Add conditonal Sendability conformance to ServerTimestamp Nov 22, 2024
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ncooke3 ncooke3 enabled auto-merge (squash) November 22, 2024 17:40
@ncooke3 ncooke3 merged commit 700fd68 into main Nov 22, 2024
35 checks passed
@ncooke3 ncooke3 deleted the nc/firestore-servertimestamp branch November 22, 2024 18:09
@firebase firebase locked and limited conversation to collaborators Dec 23, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ServerTimestamp<T> could be sendable if T is Sendable
3 participants