Skip to content

[Auth] Add support for upcoming Recaptcha changes #14201

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 14 commits into from
Feb 3, 2025
Merged

[Auth] Add support for upcoming Recaptcha changes #14201

merged 14 commits into from
Feb 3, 2025

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Dec 2, 2024

Corresponding PR for google/interop-ios-for-google-sdks#16 that is backwards compatible for Recaptcha ≤18.6 (edit: backwards compatible is not needed due to dependency versioning)

Support Cases

  1. Old Recaptcha x Old Firebase → ✅ Will continue to work, no changes
  2. Old Recaptcha x New Firebase → ❌ Won't work because of conflicting recaptcha interop dependency
  3. New Recaptcha x Old Firebase → ❌ Won't work because of conflicting recaptcha interop dependency
  4. New Recaptcha x New Firebase → ✅ Will work bc of this PR

Testing (manual tests– is reCaptcha token generated?)

  • CocoaPods - dynamic linking
  • CocoaPods - static linking
  • SPM manual test
  • Zip manual test (will wait for new Recaptcha interop and Recaptcha SDK to be released)
  • SPM: try await Auth.auth().initializeRecaptchaConfig() throws error when Recaptcha is not linked

TODOs

  • Looking into the existing rCE unit test PRs to see if we can get unit tests checked in too

cc: @walterjgsp

@ncooke3 ncooke3 marked this pull request as ready for review December 6, 2024 16:19
@ncooke3 ncooke3 added this to the 11.7.0 - M158 milestone Dec 6, 2024
@ncooke3
Copy link
Member Author

ncooke3 commented Dec 6, 2024

Adding this to M158 milestone for consideration. Will probably slip to M159.

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting rid of the ObjC!

@ncooke3 ncooke3 modified the milestones: 11.7.0 - M158, 11.8.0 - M159 Jan 7, 2025
@ncooke3
Copy link
Member Author

ncooke3 commented Jan 7, 2025

Moved back to a later milestone as new Recaptcha version is not yet released.

@ncooke3 ncooke3 modified the milestones: 11.8.0 - M159, 11.9.0 - M160 Jan 28, 2025
@ncooke3
Copy link
Member Author

ncooke3 commented Jan 28, 2025

Moved back to a later milestone as new Recaptcha version is not yet released.

@ncooke3 ncooke3 merged commit cae7c38 into main Feb 3, 2025
79 checks passed
@ncooke3 ncooke3 deleted the nc/recaptcha branch February 3, 2025 16:40
@firebase firebase locked and limited conversation to collaborators Mar 6, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants