Update to gRPC 1.69.0 #14342
Merged
Update to gRPC 1.69.0 #14342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
@cherylEnkidu @ncooke3 The binary distribution will also need to be updated before the next release.
paulb777
reviewed
Jan 13, 2025
|
@paulb777 @cherylEnkidu After firebase/abseil-cpp-SwiftPM#25 was merged, the abseil issue is resolved for this PR and the bots pass. We should be good to merge this PR. PTAL |
paulb777
approved these changes
Feb 3, 2025
| @@ -1365,7 +1365,7 @@ func grpcDependency() -> Package.Dependency { | |||
| // If building Firestore from source, abseil will need to be built as source | |||
| // as the headers in the binary version of abseil are unusable. | |||
| if ProcessInfo.processInfo.environment["FIREBASE_SOURCE_FIRESTORE"] != nil { | |||
| packageInfo = ("https://github.com/grpc/grpc-ios.git", "1.65.0" ..< "1.66.0") | |||
| packageInfo = ("https://github.com/grpc/grpc-ios.git", "1.69.0" ..< "1.70.0") | |||
| } else { | |||
| packageInfo = ("https://github.com/google/grpc-binary.git", "1.65.1" ..< "1.66.0") | |||
There was a problem hiding this comment.
This can be updated in a follow-up PR. Please coordinate with @ncooke3 to do so.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the gRPC version to pick up the fix mentioned in #14323 (comment)