Skip to content

Firestore: pin googletest to a commit that supports c++14 in cmake builds #14474

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Feb 20, 2025
Merged

Firestore: pin googletest to a commit that supports c++14 in cmake builds #14474

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
da81417
compiler_setup.cmake: specify -Wno-error=deprecated-declarations to a…
dconeybe Feb 20, 2025
f0a3334
Firestore/core/test/unit/util/CMakeLists.txt: remove set(CMAKE_CXX_EX…
dconeybe Feb 20, 2025
f87cb72
Revert "Firestore/core/test/unit/util/CMakeLists.txt: remove set(CMAK…
dconeybe Feb 20, 2025
f0ff19e
googletest.cmake: pin to the last commit that has c++14 support
dconeybe Feb 20, 2025
6be859f
Revert "compiler_setup.cmake: specify -Wno-error=deprecated-declarati…
dconeybe Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cmake/external/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,12 @@ endif()

# Note: googletest lives at head and encourages to just point to a head commit.
# https://github.com/google/googletest/blob/bf66935e07/README.md?plain=1#L5-L10
set(version main)

# Commit 4a00a24fff was chosen because it is the _last_ commit before googletest
# dropped c++14 support, setting the floor to c++17. Once Firebase sets _its_
# floor to c++17, this pinned commit can be moved to a new one.
# See https://github.com/firebase/firebase-ios-sdk/pull/14474.
set(version 4a00a24fff)

ExternalProject_Add(
googletest
Expand Down
Loading