Skip to content

remove useless method #14544

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 7, 2025
+0 −30
Merged

remove useless method #14544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions Crashlytics/Crashlytics/Components/FIRCLSApplication.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,6 @@ UIApplication* FIRCLSApplicationSharedInstance(void);
id FIRCLSApplicationSharedInstance(void);
#endif

void FIRCLSApplicationOpenURL(NSURL* url,
NSExtensionContext* extensionContext,
void (^completionBlock)(BOOL success));

id<NSObject> FIRCLSApplicationBeginActivity(NSActivityOptions options, NSString* reason);
void FIRCLSApplicationEndActivity(id<NSObject> activity);

Expand Down
26 changes: 0 additions & 26 deletions Crashlytics/Crashlytics/Components/FIRCLSApplication.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,32 +155,6 @@ id FIRCLSApplicationSharedInstance(void) {
}
#endif

void FIRCLSApplicationOpenURL(NSURL* url,
NSExtensionContext* extensionContext,
void (^completionBlock)(BOOL success)) {
if (extensionContext) {
[extensionContext openURL:url completionHandler:completionBlock];
return;
}

BOOL result = NO;

#if TARGET_OS_IOS
// What's going on here is the value returned is a scalar, but we really need an object to
// call this dynamically. Hoops must be jumped.
NSInvocationOperation* op =
[[NSInvocationOperation alloc] initWithTarget:FIRCLSApplicationSharedInstance()
selector:@selector(openURL:)
object:url];
[op start];
[op.result getValue:&result];
#elif CLS_TARGET_OS_OSX
result = [[NSClassFromString(@"NSWorkspace") sharedWorkspace] openURL:url];
#endif

completionBlock(result);
}

id<NSObject> FIRCLSApplicationBeginActivity(NSActivityOptions options, NSString* reason) {
if ([[NSProcessInfo processInfo] respondsToSelector:@selector(beginActivityWithOptions:
reason:)]) {
Expand Down
Loading