Skip to content

[Infra] Install visionOS sim in storage x spm workflow #14579

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Mar 14, 2025

Fix #14578

Job fixed:
Screenshot 2025-03-14 at 10 11 43 AM

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@ncooke3 ncooke3 requested a review from andrewheard March 14, 2025 14:11
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We had the same thing leftover in the Vertex AI workflows and looks like it helps here too:

run: xcodebuild -downloadPlatform visionOS

As far as I know, it's a no-op when it's available so that's good too.

@ncooke3 ncooke3 merged commit 0f6a23a into main Mar 14, 2025
45 of 46 checks passed
@ncooke3 ncooke3 deleted the ncooke3-patch-4 branch March 14, 2025 15:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly Testing Report
2 participants