[Functions] 'call' API should reenter on main thread #14667
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
| @@ -79,7 +79,7 @@ open class HTTPSCallable: NSObject { | |||
| completion: @escaping (HTTPSCallableResult?, | |||
| Error?) -> Void) { | |||
| if #available(iOS 13, macCatalyst 13, macOS 10.15, tvOS 13, watchOS 7, *) { | |||
| Task { | |||
| Task { @MainActor in | |||
| do { | |||
| let result = try await call(data) | |||
There was a problem hiding this comment.
Should only the completion be on the MainActor? Could the call lock it up?
There was a problem hiding this comment.
I thought the same thing. I dropped a breakpoint in call and it was off the main thread.
There was a problem hiding this comment.
So the call will execute off of the main thread and won't block. We could be more precise and wrap the completion specifically which is arguably more defensive in case the logic in this scope grows and we want to minimize the work that occurs on the main thread.
There was a problem hiding this comment.
Why not be more precise? That would also be consistent with how Auth typically does completions.
ObjC regression tests (after deflaking): https://github.com/firebase/firebase-ios-sdk/actions/runs/14314286364/job/40119407605?pr=14667
Fix #14653