Skip to content

[Sessions] Migrate to import access modifiers #14670

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Apr 8, 2025
Merged

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Apr 7, 2025

My plan: In the first pass, I'm going to use the explicit internal as a marker that I've audited the import. After I'm done migrating the implementationOnly -> internal, I can audit the un-prefixed import we have remaining as those may need to be marked internal or public (or are unused). After that audit, we can turn on internal by default.

#no-changelog

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

ncooke3 added 2 commits April 8, 2025 16:21
I believe scripts/test_catalyst.sh needs to change. Since many workflow files use it, I'll do a
separate catalyst PR.
@ncooke3 ncooke3 force-pushed the nc/sessions-imports branch from 0b03c83 to 9b0f1f2 Compare April 8, 2025 20:21
@ncooke3 ncooke3 requested review from paulb777 and andrewheard April 8, 2025 20:49
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ncooke3 ncooke3 merged commit cb10f05 into main Apr 8, 2025
41 checks passed
@ncooke3 ncooke3 deleted the nc/sessions-imports branch April 8, 2025 21:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants