Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Vertex AI] Add minItems and maxItems to Schema #14671

Merged
merged 4 commits into from
Apr 10, 2025

Conversation

andrewheard
Copy link
Contributor

Added support for specifying the minimum and maximum number of items (minItems / maxItems) to generate in an array Schema. These are two of the fields planned for #14647.

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces minItems and maxItems properties to the Schema class, allowing developers to specify the minimum and maximum number of items in an array schema. The changes are well-structured and the new functionality is integrated seamlessly. The addition of a unit test is also a great practice.

Merge Readiness

The code is well-structured, includes a unit test, and introduces a useful feature. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging. I believe this pull request is ready to be merged.

@andrewheard andrewheard marked this pull request as ready for review April 10, 2025 15:50
# Conflicts:
#	FirebaseVertexAI/CHANGELOG.md
@andrewheard andrewheard merged commit 56301dd into main Apr 10, 2025
36 checks passed
@andrewheard andrewheard deleted the ah/vertex-schema-items branch April 10, 2025 16:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants