-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Vertex AI] Add minItems
and maxItems
to Schema
#14671
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces minItems
and maxItems
properties to the Schema
class, allowing developers to specify the minimum and maximum number of items in an array schema. The changes are well-structured and the new functionality is integrated seamlessly. The addition of a unit test is also a great practice.
Merge Readiness
The code is well-structured, includes a unit test, and introduces a useful feature. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging. I believe this pull request is ready to be merged.
# Conflicts: # FirebaseVertexAI/CHANGELOG.md
Added support for specifying the minimum and maximum number of items (
minItems
/maxItems
) to generate in an arraySchema
. These are two of the fields planned for #14647.