Skip to content

[Vertex AI] Use ephemeral URLSession config on iOS 18.4 sim #14696

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 11 commits into from
Apr 11, 2025

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Apr 9, 2025

Resolved an issue with network requests failing in the iOS 18.4 and visionOS 2.4 simulators (included with Xcode 16.3) due to a bug in URLSession. The workaround is to use an ephemeral URLSession configuration when running in these simulators. See https://developer.apple.com/forums/thread/777999 for more details.

Note: Behaviour on older simulators and physical devices is unchanged.

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts

# Conflicts:
#	FirebaseVertexAI/Sources/GenerativeModel.swift
@andrewheard andrewheard changed the title [Vertex AI] Use URLSession(configuration: .ephemeral) on iOS 18.4 sim [Vertex AI] Use ephemeral URLSession(configuration: .ephemeral) on iOS 18.4 sim Apr 10, 2025
@andrewheard andrewheard changed the title [Vertex AI] Use ephemeral URLSession(configuration: .ephemeral) on iOS 18.4 sim [Vertex AI] Use ephemeral URLSession config on iOS 18.4 sim Apr 10, 2025
@andrewheard
Copy link
Contributor Author

@andrewheard andrewheard marked this pull request as ready for review April 10, 2025 01:51
@andrewheard andrewheard requested a review from paulb777 April 10, 2025 01:51
@paulb777
Copy link
Member

BTW, it should now be safe to update ci for Xcode 16.3

@paulb777 paulb777 added this to the 11.12.0 - M163 milestone Apr 11, 2025
@andrewheard andrewheard merged commit c0b399e into main Apr 11, 2025
36 checks passed
@andrewheard andrewheard deleted the ah/vertex-urlsession branch April 11, 2025 21:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants