-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[Vertex AI] Use ephemeral URLSession
config on iOS 18.4 sim
#14696
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conflicts
# Conflicts: # FirebaseVertexAI/Sources/GenerativeModel.swift
URLSession(configuration: .ephemeral)
on iOS 18.4 simURLSession(configuration: .ephemeral)
on iOS 18.4 sim
URLSession(configuration: .ephemeral)
on iOS 18.4 simURLSession
config on iOS 18.4 sim
This reverts commit f457d7c.
Integration tests passing on Xcode 16.3: https://github.com/firebase/firebase-ios-sdk/actions/runs/14370378116/job/40292399998?pr=14696#step:8:1442 |
BTW, it should now be safe to update ci for Xcode 16.3 |
# Conflicts: # FirebaseVertexAI/CHANGELOG.md
Resolved an issue with network requests failing in the iOS 18.4 and visionOS 2.4 simulators (included with Xcode 16.3) due to a bug in
URLSession
. The workaround is to use an ephemeralURLSession
configuration when running in these simulators. See https://developer.apple.com/forums/thread/777999 for more details.Note: Behaviour on older simulators and physical devices is unchanged.