-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Minimize signins in VertexAI integration tests #14697
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request aims to minimize sign-ins in VertexAI integration tests by checking if a user is already signed in before attempting to # again. This is a good optimization that can reduce the load on the authentication backend and speed up the tests. The changes look good overall, but I have a few minor suggestions.
Merge Readiness
The changes look good and address the issue of minimizing sign-ins in integration tests. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging. There are no critical or high severity issues, so the pull request is ready to be merged after addressing the comments.
FirebaseVertexAI/Tests/TestApp/Tests/Integration/GenerateContentIntegrationTests.swift
Outdated
Show resolved
Hide resolved
FirebaseVertexAI/Tests/TestApp/Tests/Integration/ImagenIntegrationTests.swift
Outdated
Show resolved
Hide resolved
FirebaseVertexAI/Tests/TestApp/Tests/Integration/IntegrationTests.swift
Outdated
Show resolved
Hide resolved
27534db
to
167f385
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Paul! I like this approach.
Avoid password request overflows to the backend
#no-changelog