Skip to content

Minimize signins in VertexAI integration tests #14697

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Apr 10, 2025
Merged

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Apr 9, 2025

Avoid password request overflows to the backend

#no-changelog

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@paulb777
Copy link
Member Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request aims to minimize sign-ins in VertexAI integration tests by checking if a user is already signed in before attempting to # again. This is a good optimization that can reduce the load on the authentication backend and speed up the tests. The changes look good overall, but I have a few minor suggestions.

Merge Readiness

The changes look good and address the issue of minimizing sign-ins in integration tests. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging. There are no critical or high severity issues, so the pull request is ready to be merged after addressing the comments.

@paulb777 paulb777 force-pushed the pb-minimize-signins branch from 27534db to 167f385 Compare April 10, 2025 01:14
@paulb777 paulb777 closed this Apr 10, 2025
@paulb777 paulb777 reopened this Apr 10, 2025
@paulb777 paulb777 requested a review from andrewheard April 10, 2025 01:24
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Paul! I like this approach.

@paulb777 paulb777 merged commit 20d9c36 into main Apr 10, 2025
69 checks passed
@paulb777 paulb777 deleted the pb-minimize-signins branch April 10, 2025 01:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants