Adding Sample App Changes #14985
Open
Adding Sample App Changes #14985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Generated by 🚫 Danger |
ncooke3
approved these changes
Jun 18, 2025
| @@ -1,4 +1,4 @@ | |||
| // Copyright 2025 Google LLC | |||
There was a problem hiding this comment.
Thanks Nick, Just a typo on my part — fixed it.
pashanka
approved these changes
Jun 19, 2025
Comment on lines
1100
to
1122
| // 1. Prompt for the custom OIDC token and await user input. | ||
| guard let idToken = await showTextInputPrompt(with: "Enter OIDC Token:") else { | ||
| print("Token exchange cancelled: OIDC Token was not provided.") | ||
| // Present an alert on the main thread to indicate cancellation. | ||
| DispatchQueue.main.async { | ||
| let alert = UIAlertController(title: "Cancelled", | ||
| message: "An OIDC Token is required to proceed.", | ||
| preferredStyle: .alert) | ||
| alert.addAction(UIAlertAction(title: "OK", style: .default)) | ||
| self.present(alert, animated: true) | ||
| } | ||
| return | ||
| } | ||
|
|
||
| // 2. Prompt for the IDP Config ID and await user input. | ||
| guard let idpConfigId = await showTextInputPrompt(with: "Enter IDP Config ID:") else { | ||
| print("Token exchange cancelled: IDP Config ID was not provided.") | ||
| // Present an alert on the main thread to indicate cancellation. | ||
| DispatchQueue.main.async { | ||
| let alert = UIAlertController(title: "Cancelled", | ||
| message: "An IDP Config ID is required to proceed.", | ||
| preferredStyle: .alert) | ||
| alert.addAction(UIAlertAction(title: "OK", style: .default)) |
There was a problem hiding this comment.
nit: Shouldn't the order of this prompt be the other way, get the idpConfigId first and then it's corresponding token?
There was a problem hiding this comment.
Yes Pavan, this would be more intuitive. I’ll reorder the prompt.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the FirebaseAuth test app
AuthenticationExampleto include a new menu item for testing the "Exchange Token" feature, which is part of the Bring Your Own CIAM (BYO-CIAM) support for Regionalized GCIP.Changes:
AuthMenu.swift: Added a new case.exchangeTokenand a corresponding sectionexchangeTokenSection.AuthViewController.swift:.exchangeTokencase indidSelectRowAt.callExchangeToken()function, which prompts the user for an "OIDC Token" and "IDP Config ID" usingshowTextInputPrompt.auth().exchangeToken()async method with the provided inputs anduseStaging: true.showAlert.AppManager.swift: Modified theauth()method to return anAuthinstance configured with a defaultTenantConfig("tenantId", "prod-global"). This is necessary for theexchangeTokencalls to target a regionalized endpoint.To provide a way to manually test and demonstrate the new
Auth.exchangeToken()SDK methods within the sample applicationAuthenticationExampleenvironment.Testing:
Manual testing steps:
Also, corrects accessToken in ExchangeTokenResponse.